Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: backport txthrottler fixes from v21 #526

Merged
merged 3 commits into from
Oct 9, 2024
Merged

slack-19.0: backport txthrottler fixes from v21 #526

merged 3 commits into from
Oct 9, 2024
+321 −73

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Oct 8, 2024 •
edited
Loading

Description

Backport v21 txthrottler fixes:

  1. [release-19.0] Fix race in replicationLagModule of go/vt/throttle (#16078) vitessio/vitess#16899
  2. [release-19.0] Support passing filters to discovery.NewHealthCheck(...) (#16170) vitessio/vitess#16871

These fixes stop txthrottler from crashing vttablet

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

timvaillancourt and others added 2 commits October 8, 2024 14:46
@timvaillancourt
[release-19.0] Support passing filters to `discovery.NewHealthCheck(.…
73355bb 
…..)` (vitessio#16170) (vitessio#16871)

Signed-off-by: Tim Vaillancourt <[email protected]>
@vitess-bot @timvaillancourt
[release-19.0] Fix race in replicationLagModule of go/vt/throttle (…
b983426 
…vitessio#16078) (vitessio#16899)

Signed-off-by: Tim Vaillancourt <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt requested a review from a team as a code owner October 8, 2024 12:48
@github-actions github-actions bot added this to the v19.0.5 milestone Oct 8, 2024
tanjinx
tanjinx approved these changes Oct 9, 2024
View reviewed changes
Copy link

@tanjinx tanjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just compared the diffs, lgtm

@timvaillancourt timvaillancourt merged commit 660c7dd into slack-19.0 Oct 9, 2024
159 of 163 checks passed
@timvaillancourt timvaillancourt deleted the bp-txthrottler-fixes_slack-19.0 branch October 9, 2024 16:20
@tanjinx tanjinx mentioned this pull request Dec 30, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
Component: VTGate Component: VTTablet txthrottler Type: Throttler upstream-backport An upstream backport v19 v21-backport
Projects
None yet
Milestone
v19.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @tanjinx